Fix generics resolving in method overloads search #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exyi
approved these changes
Feb 14, 2021
There was a problem hiding this comment.
Ok, this is not worse than before. However this logic actually does not take implicit conversions into account at all, maybe we should fix that more generally. For example, this wont work:
interface A<T> { }
class B: A<int> { }
void Method<T>(I<T> x);Invoking the Method(new B()) will fail.
tomasherceg
deleted the
bugfix/findoverload-generic-array-element-enumerable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that failed method overloads search, for example in the following case:
T Method<T>(Enumerable<T> arg)T[]as the first and the only argumentTbased ontypeof(T[]).GetGenericArguments()which fails for arrays